-
Notifications
You must be signed in to change notification settings - Fork 7
Enable RCT_USE_RN_DEP in test app and assert RCT_USE_PREBUILT_RNCORE != 1
#232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
86ff582
Add matrix with prebuilds for RN core and deps enabled
kraenhansen e6f4a7b
Opt into prebuilds of React Native dependencies
kraenhansen f83e327
Simplify podspec
kraenhansen 492e09c
Ensure RCT_USE_PREBUILT_RNCORE is never enabled
kraenhansen 798840a
Revert "Add matrix with prebuilds for RN core and deps enabled"
kraenhansen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import assert from "node:assert/strict"; | ||
| import { describe, it } from "node:test"; | ||
| import cp from "node:child_process"; | ||
|
|
||
| describe("Podspec", () => { | ||
| // We cannot support prebuilds of React Native Core since we're patching JSI | ||
| it( | ||
| "should error when RCT_USE_PREBUILT_RNCORE is set", | ||
| // We cannot call `pod` on non-macOS systems | ||
| { skip: process.platform !== "darwin" }, | ||
| () => { | ||
| const { status, stdout } = cp.spawnSync("pod", ["spec", "lint"], { | ||
| env: { ...process.env, RCT_USE_PREBUILT_RNCORE: "1" }, | ||
| encoding: "utf-8", | ||
| }); | ||
|
|
||
| assert.notEqual(status, 0); | ||
| assert.match( | ||
| stdout, | ||
| /React Native Node-API cannot reliably patch JSI when React Native Core is prebuilt/, | ||
| ); | ||
| }, | ||
| ); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by deleting this as we don't support old versions of React Native anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the output when users try on an unsupported version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An error is raised: