Skip to content

Conversation

@Starosti
Copy link
Contributor

Describe your changes

Checklist

  • I have read the [CONTRIBUTING]
  • I have performed a self-review of my own code
  • I have run the code locally and it works as expected
  • I have commented my code, particularly in hard-to-understand areas

Screenshots (if appropriate)

Copy link
Owner

@canbula canbula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you return False with your __exit__ method?

@Starosti
Copy link
Contributor Author

Starosti commented Nov 5, 2024

Why do you return False with your __exit__ method?

I've added that return because I thought we needed to return False if we didn't handle the exception, as we need to return True if we handled it. Now I've read more on it I realized that I can just return anything except True and it will be fine. I have edited the code accordingly.

@Starosti Starosti requested a review from canbula November 5, 2024 09:51
Copy link
Owner

@canbula canbula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@canbula canbula merged commit 046d9f1 into canbula:master Dec 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants