fix(openstack): correct bond parameter translation for sysconfig #6576
Conversation
holmanb
added
the
CLA not signed
|
Thanks for this contribution @ftarasenko. Can you please sign the CLA? |
|
@holmanb Oh, sorry — I thought I had already signed the CLA. |
Fix regression in bond parameter handling when using OpenStack network_data.json with sysconfig renderer. The issue occurred when translating bond parameters from OpenStack format (bond_xmit_hash_policy) to cloud-init format. The previous implementation only replaced "bond_" prefix with "bond-", leaving remaining underscores unchanged. This created a mixed format like "bond-xmit_hash_policy" which didn't match either lookup variant in the sysconfig renderer: - bond_xmit_hash_policy (all underscores) - bond-xmit-hash-policy (all hyphens) As a result, bond options like xmit_hash_policy and lacp_rate were silently dropped from BONDING_OPTS in sysconfig rendering. The fix replaces ALL underscores with hyphens, ensuring parameters match the expected format in sysconfig renderer. Before: BONDING_OPTS="mode=802.3ad" After: BONDING_OPTS="mode=802.3ad xmit_hash_policy=layer3+4 lacp_rate=fast" Affects versions: 24.4+
ftarasenko
force-pushed
the
claude/compare-tags-23-24-01Qov2aZ5wGxG5TEirtbWwUJ
branch
from
4953447 to
e96a85c
Compare
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging blackboxsw, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag blackboxsw to reopen it.) |
github-actions
bot
added
the
stale-pr
|
@ftarasenko any progress on this?
If it worked when testing locally it may just require unit test updates. |
holmanb
added
incomplete
github-actions
bot
removed
the
stale-pr
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging blackboxsw, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag blackboxsw to reopen it.) |
github-actions
bot
added
the
stale-pr
github-actions
bot
removed
the
stale-pr
2 participants
Fix regression in bond parameter handling when using OpenStack network_data.json with sysconfig renderer.
The issue occurred when translating bond parameters from OpenStack format (bond_xmit_hash_policy) to cloud-init format. The previous implementation only replaced "bond_" prefix with "bond-", leaving remaining underscores unchanged. This created a mixed format like "bond-xmit_hash_policy" which didn't match either lookup variant in the sysconfig renderer:
As a result, bond options like xmit_hash_policy and lacp_rate were silently dropped from BONDING_OPTS in sysconfig rendering.
The fix replaces ALL underscores with hyphens, ensuring parameters match the expected format in sysconfig renderer.
Before: BONDING_OPTS="mode=802.3ad"
After: BONDING_OPTS="mode=802.3ad xmit_hash_policy=layer3+4 lacp_rate=fast"
Affects versions: 24.4+
Proposed Commit Message
Additional Context
Test Steps
Merge type