-
Notifications
You must be signed in to change notification settings - Fork 1k
use curl instead of wget #6610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use curl instead of wget #6610
Conversation
blackboxsw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this submission and updating docs.
Note that most of the curl replacements suggested in docs are not valid curl calls, please update and test them on a running system to make sure we are documenting functional equivalents without errors before we land it.
I'm curious which images streams you are familiar with where wget does not exist:
Looking at desktop manifest it still has wget in the image, same with ubuntu server images and ubuntu minimal images because it's pulled in by other image dependencies like pciutils which exist in most images.
| # Early boot environments can race systemd-tmpfiles-clean LP: #1707222. | ||
| - mkdir /run/mydir | ||
| - [ wget, "http://slashdot.org", -O, /run/mydir/index.html ] | ||
| - [ curl, "http://slashdot.org", -O, /run/mydir/index.html ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not valid curl commands. We should update them to commands that can run without error if we want to land this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My fail, see update please
wget Removed from Ubuntu Server 25.10 Default Install
wget Removed from Ubuntu Server 25.10 Default Install 'test_nocloud.py' fixed by instructions from https://github.com/FiloSottile/mkcert
692aab1 to
72643e9
Compare
"Ubuntu developers have decided to remove wget from the default install of Ubuntu Server 25.10, in favour of wcurl, which offers similar functionality." - from link |
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging blackboxsw, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag blackboxsw to reopen it.) |
|
@blackboxsw I don't know why the bot plans to close PR soon... But let's use curl instead of wget |
holmanb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AndreiCherniaev, this looks good to me.
Proposed Commit Message
Additional Context
Test Steps
Merge type