[Java] Support Upload status in Attachments #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
sdm/src/main/java/com/sap/cds/sdm/handler/applicationservice/SDMReadAttachmentsHandler.java
Fixed
Show fixed
Hide fixed
sdm/src/main/java/com/sap/cds/sdm/handler/applicationservice/SDMReadAttachmentsHandler.java
Fixed
Show fixed
Hide fixed
rishikunnath2747
requested changes
Jan 8, 2026
| "\"%s\" contains unsupported characters (‘/’ or ‘\\’). Rename and try again."; | ||
| public static final String SINGLE_DUPLICATE_FILENAME = | ||
| "An object named \"%s\" already exists. Rename the object and try again."; | ||
| public static final String VIRUS_DETECTED_ERROR_MSG = |
Collaborator
There was a problem hiding this comment.
Don't these messages to support internationalisation?
| && cmisDocument | ||
| .getUploadStatus() | ||
| .equalsIgnoreCase(SDMConstants.UPLOAD_STATUS_VIRUS_DETECTED)) | ||
| throw new ServiceException("Virus Detected in this file kindly delete it."); |
Collaborator
There was a problem hiding this comment.
Please update the error messages to use the SDMErrorMessages file and make it compatible for internationalisation
| long totalSize = cmisDocument.getContentLength(); | ||
| int chunkSize = SDMConstants.CHUNK_SIZE; | ||
|
|
||
| CdsModel model = eventContext.getModel(); |
|
|
||
| @Before | ||
| @HandlerOrder(OrderConstants.Before.CHECK_CAPABILITIES) | ||
| void processBeforeForDraft(CdsCreateEventContext context, List<CdsData> data) { |
|
|
||
| @Before | ||
| @HandlerOrder(OrderConstants.Before.CHECK_CAPABILITIES) | ||
| void processBeforeForDraft(CdsCreateEventContext context, List<CdsData> data) { |
|
|
||
| @Before | ||
| @HandlerOrder(OrderConstants.Before.CHECK_CAPABILITIES) | ||
| void processBeforeForDraft(CdsCreateEventContext context, List<CdsData> data) { |
|
|
||
| @Before | ||
| @HandlerOrder(OrderConstants.Before.CHECK_CAPABILITIES) | ||
| void processBeforeForDraft(CdsCreateEventContext context, List<CdsData> data) { |
| String sdmUrl, | ||
| int chunkSize, | ||
| boolean isSystemUser, | ||
| CdsEntity entity, |
| int chunkSize, | ||
| boolean isSystemUser, | ||
| CdsEntity entity, | ||
| PersistenceService persistenceService) |
Comment on lines
+216
to
+218
| Result r = | ||
| dbQuery.updateUploadStatusByScanStatus( | ||
| attachmentDraftEntity, persistenceService, objectId, scanStatusEnum); |
| doc.get("uploadStatus") | ||
| .eq(SDMConstants.UPLOAD_STATUS_IN_PROGRESS)))); | ||
|
|
||
| Result r = persistenceService.run(updateQuery); |
| SDMAttachmentsService service = spy(new SDMAttachmentsService()); | ||
| doNothing().when(service).emit(any()); | ||
| CreateAttachmentInput input = mock(CreateAttachmentInput.class); | ||
| MediaData mediaData = MediaData.create(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
As a user of CAP Application, I am able to see the status of upload of attachments so that I have transparency of documents in the SDM Backend.
SDM backend is implementing async virus scan on documents when they are uploaded on object store using Trend Micro scan. This is planned specifically for large files as Malware service has a limitation of 400 MB. SDM Tenants will have one bucket per tenant and Trend Micro is a bucket configuration. Currently this is scan only supported in GCP.
As a plugin, we will have a generic column for upload status. This will be a common and general behavior irrespective of the virus scan feature and data center.
This column will show the status for all the below use cases
Upload of attachment (Success)
Malware scanning service result (Virus scanning in Progress, Virus detected?, Success)
Trend Micro (Virus scanning in Progress, Virus detected, Success)
Any documentation
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Upload Screenshots/lists of the scenarios tested