Build static libs with PIC #2836
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Yes. Also please add a line in https://github.com/capstone-engine/capstone/blob/next/docs/cs_v6_release_guide.md about this change. |
This allows the static library to be linked into a shared object or PIE executable.
hainest
force-pushed
the
static_lib_pic
branch
from
0beac6b to
9d48515
Compare
Contributor
Author
I wasn't sure where to add it, so I put it under 'Developer improvements' since that's where several other cmake/build items were. |
jiegec
approved these changes
Dec 30, 2025
Rot127
approved these changes
Dec 30, 2025
wargio
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This allows the static library to be linked into a shared object or PIE executable without affecting non-PIC linking.
Test plan
None.
I think refactoring the
set_propertyout of theCAPSTONE_BUILD_SHARED_LIBSwould be a better change. Thoughts?