Skip to content

fix!: use distinct names for label props and slots (svelte 5 fix) #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metonym merged 21 commits into from
Dec 7, 2025
Merged

fix!: use distinct names for label props and slots (svelte 5 fix) #2408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
095b982
fix(time-picker-select)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
38aa254
fix(time-picker)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
fe4897d
fix(radio-button)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
c8f4d98
fix(tree-view)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
1c859d5
fix(checkbox)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
4784fe8
fix(slider)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
3f14a39
fix(progress-bar)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
cc5ed72
fix(combo-box)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
60f71ec
fix(select)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
5895f16
fix(multi-select)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
260c923
fix(search)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
49c43e9
fix(toggle)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
4fa647e
fix(toggle-skeleton)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
4180fb8
fix(date-picker-input)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
e82e7d4
fix(password-input)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
3698c48
fix(text-input)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
37edaa3
fix(text-area)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
d5ff7a7
fix(number-input)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
b5f9831
fix(file-uploader-button)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
01f0a9c
fix(file-uploader-drop-container)!: change labelText slot to labelChi…
spburtsev Dec 5, 2025
cc3c9ef
fix(context-menu-option)!: change labelText slot to labelChildren
spburtsev Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
214 changes: 107 additions & 107 deletions COMPONENT_INDEX.md
View file
Open in desktop

Large diffs are not rendered by default.

46 changes: 23 additions & 23 deletions docs/src/COMPONENT_API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,7 +1146,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -2187,7 +2187,7 @@
"slot_props": "{\n item: Item;\n index: number;\n}"
},
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -2860,7 +2860,7 @@
{
"name": "labelText",
"kind": "let",
"description": "Specify the label text.\nAlternatively, use the \"labelText\" slot.\n@example \n```svelte\n<ContextMenuOption>\n <span slot=\"labelText\">Custom Label</span>\n</ContextMenuOption>\n```",
"description": "Specify the label text.\nAlternatively, use the \"labelChildren\" slot.\n@example \n```svelte\n<ContextMenuOption>\n <span slot=\"labelChildren\">Custom Label</span>\n</ContextMenuOption>\n```",
"type": "string",
"value": "\"\"",
"isFunction": false,
Expand Down Expand Up @@ -2939,7 +2939,7 @@
"slot_props": "Record<string, never>"
},
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -4210,7 +4210,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -5210,7 +5210,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -5380,7 +5380,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -9490,7 +9490,7 @@
"slot_props": "{\n item: Item;\n index: number;\n}"
},
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -10180,7 +10180,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -11467,7 +11467,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -11800,7 +11800,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -12282,7 +12282,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -13074,7 +13074,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -13421,7 +13421,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -14713,7 +14713,7 @@
{
"name": "labelText",
"kind": "let",
"description": "Specify the label text.\nAlternatively, use the \"labelText\" slot.\n@example \n```svelte\n<Slider>\n <span slot=\"labelText\">Custom Label</span>\n</Slider>\n```",
"description": "Specify the label text.\nAlternatively, use the \"labelText\" slot.\n@example \n```svelte\n<Slider>\n <span slot=\"labelChildren\">Custom Label</span>\n</Slider>\n```",
"type": "string",
"value": "\"\"",
"isFunction": false,
Expand Down Expand Up @@ -14762,7 +14762,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -16781,7 +16781,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -17125,7 +17125,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -17730,7 +17730,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -17898,7 +17898,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -18290,7 +18290,7 @@
"slot_props": "Record<string, never>"
},
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -18395,7 +18395,7 @@
"moduleExports": [],
"slots": [
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down Expand Up @@ -19515,7 +19515,7 @@
"slot_props": "{\n node: {\n id: TreeNodeId;\n text: string;\n expanded: boolean;\n leaf: boolean;\n disabled: boolean;\n selected: boolean;\n };\n}"
},
{
"name": "labelText",
"name": "labelChildren",
"default": false,
"fallback": "{labelText}",
"slot_props": "Record<string, never>"
Expand Down
2 changes: 1 addition & 1 deletion src/Checkbox/Checkbox.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@
class:bx--checkbox-label-text={true}
class:bx--visually-hidden={hideLabel}
>
<slot name="labelText">
<slot name="labelChildren">
{labelText}
</slot>
</span>
Expand Down
4 changes: 2 additions & 2 deletions src/ComboBox/ComboBox.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,14 +312,14 @@
/>

<div class:bx--list-box__wrapper={true}>
{#if labelText || $$slots.labelText}
{#if labelText || $$slots.labelChildren}
<label
for={id}
class:bx--label={true}
class:bx--label--disabled={disabled}
class:bx--visually-hidden={hideLabel}
>
<slot name="labelText">
<slot name="labelChildren">
{labelText}
</slot>
</label>
Expand Down
8 changes: 4 additions & 4 deletions src/ContextMenu/ContextMenuOption.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@

/**
* Specify the label text.
* Alternatively, use the "labelText" slot.
* Alternatively, use the "labelChildren" slot.
* @example
* ```svelte
* <ContextMenuOption>
* <span slot="labelText">Custom Label</span>
* <span slot="labelChildren">Custom Label</span>
* </ContextMenuOption>
* ```
*/
Expand Down Expand Up @@ -380,7 +380,7 @@
</div>
{/if}
<span class:bx--menu-option__label={true} title={labelText}>
<slot name="labelText">{labelText}</slot>
<slot name="labelChildren">{labelText}</slot>
</span>
<div class:bx--menu-option__info={true}><CaretRight /></div>
</div>
Expand All @@ -406,7 +406,7 @@
</div>
{/if}
<span class:bx--menu-option__label={true} title={labelText}>
<slot name="labelText">{labelText}</slot>
<slot name="labelChildren">{labelText}</slot>
</span>
<div class:bx--menu-option__info={true}>
<slot name="shortcutText">{shortcutText}</slot>
Expand Down
4 changes: 2 additions & 2 deletions src/DatePicker/DatePickerInput.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,14 @@
class:bx--date-picker-container={true}
class:bx--date-picker--nolabel={!labelText}
>
{#if labelText || $$slots.labelText}
{#if labelText || $$slots.labelChildren}
<label
for={id}
class:bx--label={true}
class:bx--visually-hidden={hideLabel}
class:bx--label--disabled={disabled}
>
<slot name="labelText">
<slot name="labelChildren">
{labelText}
</slot>
</label>
Expand Down
2 changes: 1 addition & 1 deletion src/FileUploader/FileUploaderButton.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
class:bx--btn--xl={size === "xl"}
on:keydown
>
<slot name="labelText">
<slot name="labelChildren">
{labelText}
</slot>
</button>
Expand Down
2 changes: 1 addition & 1 deletion src/FileUploader/FileUploaderDropContainer.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
class:bx--file__drop-container={true}
class:bx--file__drop-container--drag-over={over}
>
<slot name="labelText">
<slot name="labelChildren">
{labelText}
</slot>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/MultiSelect/MultiSelect.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,14 +325,14 @@
class:bx--list-box__wrapper--inline={inline}
class:bx--multi-select__wrapper--inline--invalid={inline && invalid}
>
{#if labelText || $$slots.labelText}
{#if labelText || $$slots.labelChildren}
<label
for={id}
class:bx--label={true}
class:bx--label--disabled={disabled}
class:bx--visually-hidden={hideLabel}
>
<slot name="labelText">
<slot name="labelChildren">
{labelText}
</slot>
</label>
Expand Down Expand Up @@ -580,7 +580,7 @@
if (i === filteredItems.length - 1) open = false;
}}
>
<slot slot="labelText" {item} index={i}>
<slot slot="labelChildren" {item} index={i}>
{itemToString(item)}
</slot>
</Checkbox>
Expand Down
4 changes: 2 additions & 2 deletions src/NumberInput/NumberInput.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,14 +271,14 @@
class:bx--number--sm={size === "sm"}
class:bx--number--xl={size === "xl"}
>
{#if $$slots.labelText || labelText}
{#if $$slots.labelChildren || labelText}
<label
for={id}
class:bx--label={true}
class:bx--label--disabled={disabled}
class:bx--visually-hidden={hideLabel}
>
<slot name="labelText">{labelText}</slot>
<slot name="labelChildren">{labelText}</slot>
</label>
{/if}
<div
Expand Down
2 changes: 1 addition & 1 deletion src/ProgressBar/ProgressBar.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
class:bx--progress-bar__label={true}
class:bx--visually-hidden={hideLabel}
>
<slot name="labelText">
<slot name="labelChildren">
{labelText}
</slot>
{#if status === "error" || status === "finished"}
Expand Down
4 changes: 2 additions & 2 deletions src/RadioButton/RadioButton.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@
/>
<label class:bx--radio-button__label={true} for={id}>
<span class:bx--radio-button__appearance={true}></span>
{#if labelText || $$slots.labelText}
{#if labelText || $$slots.labelChildren}
<span class:bx--visually-hidden={hideLabel}>
<slot name="labelText">
<slot name="labelChildren">
{labelText}
</slot>
</span>
Expand Down
2 changes: 1 addition & 1 deletion src/Search/Search.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
<svelte:component this={icon} class="bx--search-magnifier-icon" />
</div>
<label id="{id}-search" for={id} class:bx--label={true}>
<slot name="labelText">
<slot name="labelChildren">
{labelText}
</slot>
</label>
Expand Down
4 changes: 2 additions & 2 deletions src/Select/Select.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,14 +143,14 @@
class:bx--select--disabled={disabled}
class:bx--select--warning={warn}
>
{#if !noLabel && (labelText || $$slots.labelText)}
{#if !noLabel && (labelText || $$slots.labelChildren)}
<label
for={id}
class:bx--label={true}
class:bx--visually-hidden={hideLabel}
class:bx--label--disabled={disabled}
>
<slot name="labelText">
<slot name="labelChildren">
{labelText}
</slot>
</label>
Expand Down
Loading