Document adapter error handling requirements and add propagation tests #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users cannot catch adapter errors with
pcall()when using database adapters (e.g., PostgreSQL with wrong credentials). Errors appear in logs butpcall()returns success. Root cause: adapters log errors instead of raising them.Changes
Interface Documentation
@raisesrequirement toAdapterandFilteredAdapterinterface methodserror()on failure, not just loggingUser Documentation
Test Coverage
tests/persist/error_handling_spec.luaverifying errors propagate through:loadPolicy()callsloadFilteredPolicy()callsNote
lua-casbin core code already propagates errors correctly. This documents the contract so adapter implementations follow it.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.