Fix failing 041.phpt on x64 Windows #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For LLP64, a `long` is 32bit, what causes 041.phpt to fail on 64bit Windows. However, as of PHP 7.0.0, integers are stored as `zend_long` by the engine, so we can fix that test failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For LLP64, a
longis 32bit, what causes 041.phpt to fail on 64bitWindows. However, as of PHP 7.0.0, integers are stored as
zend_longby the engine, so we can fix that test failure.
If that was the only issue regarding
long, I think this patch would be okay. However, there are a lot more issues (and some are way more serious, such as passing along*tozend_parse_parameters()), so there'd need to be an abstraction layer. Or maybe, consider to drop support for PHP < 7.0.0.