Skip to content

Update node-binance-api.js #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxah wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update node-binance-api.js #734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions node-binance-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ let api = function Binance( options = {} ) {
}
if ( Binance.options.useServerTime ) {
publicRequest( base + 'v3/time', {}, function ( error, response ) {
Binance.info.timeOffset = response.serverTime - new Date().getTime();
Binance.info.timeOffset = response.serverTime - Date.now();
//Binance.options.log("server time set: ", response.serverTime, Binance.info.timeOffset);
if ( callback ) callback();
} );
Expand Down Expand Up @@ -170,7 +170,7 @@ let api = function Binance( options = {} ) {
}

const reqHandler = cb => ( error, response, body ) => {
Binance.info.lastRequest = new Date().getTime();
Binance.info.lastRequest = Date.now();
if ( response ) {
Binance.info.statusCode = response.statusCode || 0;
if ( response.request ) Binance.info.lastURL = response.request.uri.href;
Expand Down Expand Up @@ -325,7 +325,7 @@ let api = function Binance( options = {} ) {
*/
const signedRequest = ( url, data = {}, callback, method = 'GET', noDataInSignature = false ) => {
requireApiSecret( 'signedRequest' );
data.timestamp = new Date().getTime() + Binance.info.timeOffset;
data.timestamp = Date.now() + Binance.info.timeOffset;
if ( typeof data.recvWindow === 'undefined' ) data.recvWindow = Binance.options.recvWindow;
let query = method === 'POST' && noDataInSignature ? '' : makeQueryString( data );
let signature = crypto.createHmac( 'sha256', Binance.options.APISECRET ).update( query ).digest( 'hex' ); // set the HMAC hash header
Expand Down Expand Up @@ -544,7 +544,7 @@ let api = function Binance( options = {} ) {
};
if ( flags.type === 'SIGNED' || flags.type === 'TRADE' || flags.type === 'USER_DATA' ) {
if ( !requireApiSecret( 'promiseRequest' ) ) return reject( 'promiseRequest: Invalid API Secret!' );
data.timestamp = new Date().getTime() + Binance.info.timeOffset;
data.timestamp = Date.now() + Binance.info.timeOffset;
query = makeQueryString( data );
data.signature = crypto.createHmac( 'sha256', Binance.options.APISECRET ).update( query ).digest( 'hex' ); // HMAC hash header
opt.url = `${ baseURL }${ url }?${ query }&signature=${ data.signature }`;
Expand All @@ -559,7 +559,7 @@ let api = function Binance( options = {} ) {
request( addProxy( opt ), ( error, response, body ) => {
if ( error ) return reject( error );
try {
Binance.info.lastRequest = new Date().getTime();
Binance.info.lastRequest = Date.now();
if ( response ) {
Binance.info.statusCode = response.statusCode || 0;
if ( response.request ) Binance.info.lastURL = response.request.uri.href;
Expand Down Expand Up @@ -3662,7 +3662,7 @@ let api = function Binance( options = {} ) {
}
publicRequest( base + 'v3/time', {}, function ( error, response ) {
if ( !error ) {
Binance.info.timeOffset = response.serverTime - new Date().getTime();
Binance.info.timeOffset = response.serverTime - Date.now();
//Binance.options.log("server time set: ", response.serverTime, Binance.info.timeOffset);
}
callback( error, response );
Expand All @@ -3671,7 +3671,7 @@ let api = function Binance( options = {} ) {
} else {
publicRequest( base + 'v3/time', {}, function ( error, response ) {
if ( !error ) {
Binance.info.timeOffset = response.serverTime - new Date().getTime();
Binance.info.timeOffset = response.serverTime - Date.now();
//Binance.options.log("server time set: ", response.serverTime, Binance.info.timeOffset);
}
callback( error, response );
Expand Down