Skip to content

chore: several fixes #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosmiei merged 1 commit into from
Aug 14, 2025
Merged

chore: several fixes #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions php-binance-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ class API

public $headers = [];

private $SPOT_ORDER_PREFIX = "x-HNA2TXFJ";
private $CONTRACT_ORDER_PREFIX = "x-Cb7ytekJ";
private $SPOT_ORDER_PREFIX = "x-B3AUXNYV";
private $CONTRACT_ORDER_PREFIX = "x-ftGmvgAN";

/**
* Constructor for the class,
Expand Down Expand Up @@ -5674,7 +5674,7 @@ public function futuresReduceMargin(string $symbol, string $amount, $positionSid
* @property int $weight 5
*
* @param string $symbol (optional) market symbol (e.g. ETHUSDT)
* @param array $params (optional) an array of additional parameters that the API endpoint allows
* @param array $params (optional) an array of additional parameters that the API endpoint afllows
* - @param int $params['recvWindow'] (optional) the time in milliseconds to wait for the response
* @param string $api_version (optional) API version, "v2" or "v3" (default is v3)
*
Expand Down
4 changes: 2 additions & 2 deletions tests/BinanceLiveTests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ public function setUp(): void {
private $quoteId = 'testQuoteId';
private $timeInForce = 'GTC';

private $SPOT_ORDER_PREFIX = "x-HNA2TXFJ";
private $CONTRACT_ORDER_PREFIX = "x-Cb7ytekJ";
private $SPOT_ORDER_PREFIX = "x-B3AUXNYV";
private $CONTRACT_ORDER_PREFIX = "x-ftGmvgAN";

public function testPricesSpot()
{
Expand Down
4 changes: 2 additions & 2 deletions tests/BinanceStaticTests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ class BinanceStaticTests extends TestCase
public static $capturedBody = null;
private MockBinanceAPI $binance;

private $SPOT_ORDER_PREFIX = "x-HNA2TXFJ";
private $CONTRACT_ORDER_PREFIX = "x-Cb7ytekJ";
private $SPOT_ORDER_PREFIX = "x-B3AUXNYV";
private $CONTRACT_ORDER_PREFIX = "x-ftGmvgAN";

// Default values for the tests
private $symbol = 'ETHUSDT';
Expand Down