This repository was archived by the owner on Oct 3, 2023. It is now read-only.
skip exporting points with no value due to prometheus staleness markers#303
Open
kwiesmueller wants to merge 1 commit intocensus-ecosystem:masterfrom
Open
skip exporting points with no value due to prometheus staleness markers#303kwiesmueller wants to merge 1 commit intocensus-ecosystem:masterfrom
kwiesmueller wants to merge 1 commit intocensus-ecosystem:masterfrom
Conversation
Contributor
Author
|
/assign @dashpole |
Contributor
Author
|
Actually, my test just failed as we're now sending timeseries with no points which is also not okay :-/ |
bffcda0 to
ef6be80
Compare
ef6be80 to
68f8441
Compare
Contributor
Author
|
Alright, works now in our collector. |
Contributor
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes cases where a staleness marker causes errors like:
By properly dropping any point that is a staleness marker instead of exporting them without a value.
The fixed issue was introduced with #300.
The bug should not cause any data loss, it just causes error logs and an increase in exporter error metrics.