feat: add search + highlight to experimental timeline flamechart #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added SearchManager class for generic search management of timeline events. - Introduced SearchStyleRenderer for rendering rectangles with search-aware styling. - Created TimelineSearchManager to encapsulate search logic, state management, and navigation. - Added utility functions for converting LogEvent hierarchies to TreeNode structures. - Updated type definitions in flamechart.types.ts and search.types.ts for better type safety. - Enhanced TimelineViewport with a method to center on specific events. - Refactored existing code to utilize new types and structures for improved maintainability.
lcottercertinia
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
add search + highlight behaviour to experimental timeline flamechart
🧩 Type of change (check all applicable)
📷 Screenshots / gifs / video [optional]
Show off your UI changes.
🔗 Related Issues
fixes #
resolves #
closes #
related #262
related #564
✅ Tests added?
📚 Docs updated?
Anything else we need to know? [optional]