Add 3 functions to simulate genotypes/allele counts for quick protyping#281
Open
hardingnj wants to merge 4 commits intocggh:masterfrom
Open
Add 3 functions to simulate genotypes/allele counts for quick protyping#281hardingnj wants to merge 4 commits intocggh:masterfrom
hardingnj wants to merge 4 commits intocggh:masterfrom
Conversation
|
Hello @hardingnj! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-11-05 15:34:04 UTC |
alimanfoo
reviewed
Jul 26, 2019
allel/simulate/simulate.py
Outdated
| return GenotypeDaskArray(g) | ||
|
|
||
|
|
||
| def simulate_allele_counts_array(n_variants, n_samples, p=(0.95, 0.05), ploidy=2): |
Contributor
There was a problem hiding this comment.
Suggested change
| def simulate_allele_counts_array(n_variants, n_samples, p=(0.95, 0.05), ploidy=2): | |
| def simulate_genotype_allele_counts(n_variants, n_samples, p=(0.95, 0.05), ploidy=2): |
allel/simulate/simulate.py
Outdated
|
|
||
|
|
||
| def simulate_genotypes(n_variants, n_samples, p=(0.95, 0.05), ploidy=2): | ||
| """generate genotypes from a random distribution |
Contributor
There was a problem hiding this comment.
Suggest capitalize and full stop like regular sentence, also for parameters.
hardingnj
changed the title
Collaborator
Author
|
Revisited after a hiatus, apologies for that. Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three simple functions that return
daskobjects.Unsure how to generalise to return in-memory objects if required.