Write from Zarr to vcf#299
Open
giang-nghg wants to merge 6 commits intocggh:masterfrom
Mykrobe-tools:feature/writing-genotype-data-to-vcf
Open
Write from Zarr to vcf#299giang-nghg wants to merge 6 commits intocggh:masterfrom Mykrobe-tools:feature/writing-genotype-data-to-vcf
giang-nghg wants to merge 6 commits intocggh:masterfrom
Mykrobe-tools:feature/writing-genotype-data-to-vcf
Conversation
- Update callset normalizing function, which failed to get grouped keys from Zarr storage, probably due to being out of date with Zarr. - Add code for writing genotype data.
- Said code was deleted in the last commit
- Since it also has `keys()` method, the check for NumPy array would also apply to it (and so the wrong code block would get executed)
|
Hello @giang-nghg! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-01-30 09:47:56 UTC |
Contributor
|
Hi @giang-nghg, just to say belated thank you for submitting this PR. Currently I'm overcommitted and so struggling to make time for development work, apologies for slowness. |
Author
|
@alimanfoo np, glad I could contribute something :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add code to write data (including genotype calling, but still lacking some info) from Zarr to VCF.
Only tested with Zarr, not other array types yet.