-
Notifications
You must be signed in to change notification settings - Fork 8
shellcheck_run_steps.py: read arch from pkg YAML #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shellcheck_run_steps.py: read arch from pkg YAML #17
Conversation
…ile portion to prevent architecture specific packages to fail Signed-off-by: Azimjon Ulmasov <azimjon.ulmasov@chainguard.dev>
Signed-off-by: Azimjon Ulmasov <azimjon.ulmasov@chainguard.dev>
c8e17ed to
cdaf3eb
Compare
dannf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just look at the melange YAML and parse target-architectures. if that field exists, use the first arch it lists. If it doesn't exist, maybe just use x86_64.
682d899 to
825c568
Compare
dannf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! I like this better. A few more comments inline.
Signed-off-by: Azimjon Ulmasov <azimjon.ulmasov@chainguard.dev>
825c568 to
b10a5b1
Compare
Signed-off-by: Azimjon Ulmasov <azimjon.ulmasov@chainguard.dev>
Read architecture from the package definition or default to
x86_64to prevent architecture specific packages to fail.Example:
raspberry-pi-utils.yamlpackage failed to pass the lint phase as we were usingos.uname().machineof the CI environment for all the packages.