Skip to content

Conversation

@sil2100
Copy link
Member

@sil2100 sil2100 commented Sep 17, 2025

We should not add any packages to restored-packages.txt if they're already present in withdrawn-packages.txt - this can lead to unexpected behavior.

Signed-off-by: Łukasz 'sil2100' Zemczak <lukasz.zemczak@chainguard.dev>
exit 0
fi

if [ ! -f "withdrawn-packages.txt" ] || [ ! -f "restored-packages.txt" ]; then

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be the first check.

Signed-off-by: Łukasz 'sil2100' Zemczak <lukasz.zemczak@chainguard.dev>
@sil2100 sil2100 merged commit b8e0577 into chainguard-dev:main Sep 17, 2025
4 checks passed
@sil2100 sil2100 deleted the hook-restored-packages-check branch September 17, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants