feat: normalize logicalId instead of throwing error [red-71] #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miliberlin
changed the title
ferrandiaz
reviewed
Feb 4, 2026
| } | ||
|
|
||
| static sanitizeLogicalId (logicalId: string): string { | ||
| return logicalId.replace(/[^A-Za-z0-9_\-/#.]/g, '') |
Contributor
There was a problem hiding this comment.
it would be weird for the user if suddenly the logicalId changes, how about giving a warn on what is going on and what are we going to do? also, they will still have the invalid logicalId on their config right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Components
Notes for the Reviewer
New Dependency Submission