Skip to content

Comments

fix: guard against invalid versions in package.json when checking playwright version#1232

Merged
hwartig merged 1 commit intomainfrom
harry/red-167-browsers-launch-error-range-fix
Feb 20, 2026
Merged

fix: guard against invalid versions in package.json when checking playwright version#1232
hwartig merged 1 commit intomainfrom
harry/red-167-browsers-launch-error-range-fix

Conversation

@hwartig
Copy link
Contributor

@hwartig hwartig commented Feb 20, 2026

There is a possibility that the range is not valid as it could point to a local copy of the package or be something like "catalog:" with pnpm. For invalid ranges, satisfies() would return just false which we wouldn't want.

https://github.com/checkly/checkly-cli/pull/1231/changes#r2833281214

Affected Components

  • CLI

There is a possibility that the range is not valid as it could point to
a local copy of the package or be something like "catalog:" with pnpm.
For invalid ranges, satisfies() would return just false which we
wouldn't want.

https://github.com/checkly/checkly-cli/pull/1231/changes#r2833281214
@hwartig hwartig requested a review from sorccu February 20, 2026 14:08
@sorccu sorccu changed the title fix: guard agains invalid versions in package.json fix: guard against invalid versions in package.json when checking playwright version Feb 20, 2026
@hwartig hwartig merged commit d37c79c into main Feb 20, 2026
4 checks passed
@hwartig hwartig deleted the harry/red-167-browsers-launch-error-range-fix branch February 20, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants