Skip to content

Conversation

@tdehan86
Copy link

Added a "What's included" section to clarify that the Coralogix OTEL integration only sends traces, not metrics.

Users who want metrics in Coralogix can use the Prometheus integration + OTEL Collector.

Add 'What's included' section listing traces, HTTP instrumentation,
and correlation metadata. Add note clarifying that metrics are not
included and linking to Prometheus integration for metrics export.
Copy link
Contributor

@guolau guolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Thomas! Good thing to clarify for this integration. I left a few small nits 🙂

Comment on lines 70 to 71
If you are using a different trace header than the standard `traceparent`, you can configure this header in the *custom
trace header* field in the integration settings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this line be moved to above the "What's included" section (to line 57)? Seems like it's separated from the relevant section currently

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be moved up, I think?

Using these tags, you can create filters, dashboards and slice & dice your Checkly data as your runs are executed and
ingested into Coralogix as traces.

### What's included
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this content be at the beginning of the "Open Telemetry tracing integration" section?

It seems like we're just summarizing what the Coralogix OTel integration includes. I feel like it makes more sense to have this at the beginning of the section (so users can skim and see what's included) rather than at the end?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to make sure customer understand what level f integration he will get from default CX integration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough 🙂 I still think it would be better at the start of this section, but not a strong preference either way. Feel free to resolve this comment.

Make sens to keep names closer to what we have

Co-authored-by: Laura Guo <48332483+guolau@users.noreply.github.com>
Comment on lines 70 to 71
If you are using a different trace header than the standard `traceparent`, you can configure this header in the *custom
trace header* field in the integration settings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be moved up, I think?

Using these tags, you can create filters, dashboards and slice & dice your Checkly data as your runs are executed and
ingested into Coralogix as traces.

### What's included
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough 🙂 I still think it would be better at the start of this section, but not a strong preference either way. Feel free to resolve this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants