ssl_handshake is now handled by worker threads, and not by cheroot main thread#749
Closed
bmourgues wants to merge 3 commits intocherrypy:maint/10.0.xfrom
Closed
ssl_handshake is now handled by worker threads, and not by cheroot main thread#749bmourgues wants to merge 3 commits intocherrypy:maint/10.0.xfrom
bmourgues wants to merge 3 commits intocherrypy:maint/10.0.xfrom
Conversation
Member
|
@bmourgues hi, the process is to always send patches against |
Author
|
Hello, I made a new PR against main #750 , you can discard this one. About code, ssl_wrap could have been directly done in get method of threadpool, but I don't know if this would be ok with pyOpenSSL |
Member
|
Thanks. Though, you could've updated the base branch in the PR and rebased on that to keep it. I'll close this PR, so there's no confusion between the two. P.S. Try to use code highlighting when referencing snippets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ What kind of change does this PR introduce?
cheroot accepts new requests while performing ssl handshake on some connections
📋 What is the related issue number (starting with
#)#748
Resolves #748
❓ What is the current behavior? (You can also link to an open issue here)
❓ What is the new behavior (if this is a feature change)?
📋 Other information:
pre-commit is ok, except for 2 files I did not change (_compat.py and errors.py)
base branch was main/10.0.x
📋 Contribution checklist:
(If you're a first-timer, check out
this guide on making great pull requests)
the changes have been approved
and description in grammatically correct, complete sentences
This change is