Skip to content

fix: bestmove output gets sometimes split on 2 lines #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tomsons wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: bestmove output gets sometimes split on 2 lines #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/ChessKitEngineCore/EngineMessenger/EngineMessenger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ NS_SWIFT_SENDABLE
/// Engines work asynchronously so use this block to subscribe to
/// any commands received from the engine.
@property (nullable) void (^ responseHandler)(NSString * _Nonnull response);
@property (nonatomic, strong) NSMutableString *outputBuffer;
Copy link
Contributor

@Amir-Zucker Amir-Zucker Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be an ivar like the pipes/file handles/lock/engine or a property inside a class extension inside EngineMessenger.mm, no reason to expose it outside of EngineMessenger class.


/// Initializes an engine with the desired type.
///
Expand Down
34 changes: 25 additions & 9 deletions Sources/ChessKitEngineCore/EngineMessenger/EngineMessenger.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ - (id)initWithEngineType: (EngineType_objc) type {

if (self) {
_lock = [[NSLock alloc] init];
_outputBuffer = [NSMutableString string];
switch (type) {
case EngineTypeStockfish:
_engine = new StockfishEngine();
Expand Down Expand Up @@ -105,15 +106,30 @@ - (void)sendCommand: (NSString*) command {

# pragma mark Private

- (void)readStdout: (NSNotification*) notification {
[_pipeReadHandle readInBackgroundAndNotify];

NSData *data = [[notification userInfo] objectForKey:NSFileHandleNotificationDataItem];
NSArray<NSString *> *output = [[[NSString alloc] initWithData:data encoding:NSUTF8StringEncoding] componentsSeparatedByString:@"\n"];

[output enumerateObjectsUsingBlock:^(NSString * _Nonnull obj, NSUInteger idx, BOOL * _Nonnull stop) {
[self responseHandler](obj);
}];
- (void)readStdout:(NSNotification*)notification {
[_pipeReadHandle readInBackgroundAndNotify];

NSData *data = notification.userInfo[NSFileHandleNotificationDataItem];
if (!data || data.length == 0) return;

NSString *chunk = [[NSString alloc] initWithData:data encoding:NSUTF8StringEncoding];
if (!chunk) return;

[self.outputBuffer appendString:chunk];

NSArray<NSString *> *lines = [self.outputBuffer componentsSeparatedByString:@"\n"];

// Keep the last line in the buffer if it's incomplete
NSUInteger lastIndex = lines.count - 1;
for (NSUInteger i = 0; i < lastIndex; i++) {
NSString *line = lines[i];
if (line.length > 0) {
[self responseHandler](line);
}
}

// Reset the buffer with the last (possibly partial) line
[self.outputBuffer setString:lines[lastIndex]];
}

@end