Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions docs/app/components/snippets/dropdown-events-2.gts
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import Component from '@glimmer/component';
import { action } from '@ember/object';
import { task, timeout } from 'ember-concurrency';
import BasicDropdown, {
type Dropdown,
} from 'ember-basic-dropdown/components/basic-dropdown';
import BasicDropdown from 'ember-basic-dropdown/components/basic-dropdown';
import type { Dropdown } from 'ember-basic-dropdown/types';

const users = [
{ name: 'Nathan', assignment: 'CLI' },
Expand Down
7 changes: 5 additions & 2 deletions src/components/basic-dropdown-trigger.gts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@ import { concat } from '@ember/helper';
import basicDropdownTriggerModifier from '../modifiers/basic-dropdown-trigger.ts';
import { on } from '@ember/modifier';
import { fn } from '@ember/helper';
import type { Dropdown } from './basic-dropdown';
import type { HorizontalPosition, VerticalPosition } from '../types.ts';
import type {
Dropdown,
HorizontalPosition,
VerticalPosition,
} from '../types.ts';

export interface BasicDropdownTriggerSignature<
T extends keyof HTMLElementTagNameMap = 'div',
Expand Down
3 changes: 0 additions & 3 deletions src/components/basic-dropdown.gts
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ import type {
TRootEventType,
} from '../types.ts';

// To avoid breaking the current types export we need this
export type { Dropdown, DropdownActions, TRootEventType };

const UNINITIALIZED = {};
const IGNORED_STYLES = ['top', 'left', 'right', 'width', 'height'];

Expand Down