-
Notifications
You must be signed in to change notification settings - Fork 2
Bump dependencies #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tvdijen I think there is an incompatibility between SSP 2.3.5 and simplesamlphp/assert 1.8, at least when I try to use that version of assert I get a stack trace about Utils\Time calling an assert method that does not exist. I tried updating the composer.json to mark |
|
We've fixed that yesterday, but haven't tagged 2.3.6 just yet |
|
Thanks, and I could use some composer advice. Should I make the min version for this module 2.3.6 so that it aligns with the v1.8.1 assert package in this module's composer.json? Or relax the min version of assert so this package can still be installed in SSP 2.3.5 and earlier? |
|
I wouldn't change a thing.. The issue is in SSP and has to be fixed there. I'll try and do a 2.3.6-release this weekend. |
|
Tagged SSP v2.3.6 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38 +/- ##
============================================
- Coverage 95.37% 90.32% -5.05%
- Complexity 73 87 +14
============================================
Files 6 8 +2
Lines 216 310 +94
============================================
+ Hits 206 280 +74
- Misses 10 30 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #37