-
Notifications
You must be signed in to change notification settings - Fork 431
feat(backend): Add last_sign_in_at filters to getUserList #7704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(backend): Add last_sign_in_at filters to getUserList #7704
Conversation
Add support for filtering users by last sign-in timestamp ranges in the getUserList API method. This enables developers to query users based on when they last signed into their application. The new parameters use exclusive comparison operators: - last_sign_in_at_after: Returns users where last_sign_in_at > value - last_sign_in_at_before: Returns users where last_sign_in_at < value Both parameters accept Unix timestamps in milliseconds and can be used independently or combined to create date ranges. The filters are applied to both the /users and /users/count endpoints to ensure consistent pagination.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 1c2c078 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughThis pull request adds two new optional query parameters to the Users API list and count endpoints: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 🧪 Unit Test Generation v2 is now available!We have significantly improved our unit test generation capabilities. To enable: Add this to your reviews:
finishing_touches:
unit_tests:
enabled: trueTry it out by using the Have feedback? Share your thoughts on our Discord thread! Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| | 'last_sign_in_at' | ||
| >; | ||
| last_active_at_since?: number; | ||
| last_sign_in_at_after?: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙃 I believe that, despite last_active_at_since, that these should be in camelCase.
Description
Add support for filtering users by last sign-in timestamp ranges in the getUserList API method. This enables developers to query users based on when they last signed into their application.
The new parameters use exclusive comparison operators:
Both parameters accept Unix timestamps in milliseconds and can be used independently or combined to create date ranges. The filters are applied to both the /users and /users/count endpoints to ensure consistent pagination.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
last_sign_in_at_afterandlast_sign_in_at_beforeparameters. These filters apply to both list and count endpoints.✏️ Tip: You can customize this high-level summary in your review settings.