-
Notifications
You must be signed in to change notification settings - Fork 13
Fix e2e test #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e test #1010
Conversation
WalkthroughThe end-to-end GitHub Actions workflow was updated to use the latest Ubuntu runner instead of ubuntu-20.04, and Python 3.6 was removed from the test matrix. The workflow will now execute tests on Python versions 3.7 through 3.10. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/e2e.yml (2)
19-19: Runner specification: explicit versus floatingubuntu-latest
Currently you’re usingruns-on: ubuntu-latest, which will float to the newest supported Ubuntu LTS (now 22.04). This can introduce occasional changes as GitHub Images update. If you need a stable, reproducible environment for your e2e tests, consider pinning toubuntu-22.04. Otherwise, please confirm you’re OK with the floating runner.
22-22: Python matrix: removal of 3.6 and adding newer versions
Removing 3.6 aligns with its EOL; please verify no part of your code or dependencies still requires it. Also, Python 3.11 is now production-ready—consider adding it to the matrix to catch compatibility issues early.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/e2e.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: build (windows-latest, 3.6)
- GitHub Check: build (windows-latest, 3.12)
- GitHub Check: build (windows-latest, 3.11)
- GitHub Check: build (windows-latest, 3.10)
- GitHub Check: build (windows-latest, 3.9)
- GitHub Check: build (windows-latest, 3.8)
- GitHub Check: build (windows-latest, 3.7)



e2e test is stopping....
Summary by CodeRabbit