[hotfix] Fix CI by changing type for parse functions in test runners #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Oh, tests are failing. I'm gonna mention you when it's ready. Sorry. |
|
ono-max
commented
May 30, 2025
| for r in reports: | ||
| client.report(r) | ||
|
|
||
| def parse_func(p: str) -> ET.ElementTree: |
Contributor
Author
There was a problem hiding this comment.
-> ET.ElementTree[ET.Element[str]] fails tests, so I gave up adding type.
Contributor
Author
|
Sorry for waiting for you. It's ready to review this PR 👍 |
Contributor
|
Ack - I'll review this PR |
Contributor
|
I understand we shouldn't fix the lib version and should the latest one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/launchableinc/cli/actions/runs/15339403804/job/43162615978?pr=1016#step:8:18