Redone the dockerfile #1022
Merged
Redone the dockerfile #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The immediate motivation for the change was from a prospect who had the opsec policy to avoid root in containers. That in turn revealed the problem that the current container is built with venv, a rather odd choise for a container! It turns out that we probably didn't choose venv because we were clever. Rather, the base image was ubuntu and it disabled/discouraged global pip package installation as it collides with APT. I could have ignored that warning anyway, but at this point it seems to me that Ubuntu is not helping, it's hurting. So I switched to python:3.x-slim, which appears to be built with the `pip install --global xyz` mindset.
…he package locally This is better suited for automation into the release process.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reworks the Dockerfile to align with updated container policies by switching from an Ubuntu base with venv to a Python slim image that better supports global pip installations, and by building the package from a local source tree.
- Switches base image to python:3.11-slim and splits the build process into multi-stage builds.
- Installs additional dependencies and builds a wheel from the source tree.
- Implements running the container as a non-root user for improved security.
|
ono-max
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The immediate motivation for the change was from a prospect who had the opsec policy to avoid root in containers. That in turn revealed the problem that the current container is built with venv, a rather odd choise for a container!
It turns out that we probably didn't choose venv because we were clever. Rather, the base image was ubuntu and it disabled/discouraged global pip package installation as it collides with APT.
I could have ignored that warning anyway, but at this point it seems to me that Ubuntu is not helping, it's hurting. So I switched to python:3.x-slim, which appears to be built with the
pip install --global xyzmindset.The other key change was to build the package from local source tree, as opposed to install from PyPI. I expect this will be key to automate this into the release process.