Enhance longrepr handling in PytestJSONReportParser and add unit tests #1072
+98
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konboi
approved these changes
Jul 11, 2025
Contributor
Konboi
left a comment
Konboi
left a comment
There was a problem hiding this comment.
Thank you follow up, I didn't know that!
I left comment. But I'll approve not to block your task
| @@ -0,0 +1,66 @@ | |||
| import json | |||
Contributor
There was a problem hiding this comment.
If the test target file is the same, I'd like to group the test code together as well.
#1073
Contributor
Author
There was a problem hiding this comment.
Thank you! I'll merge your PR.
merge test codes to one file
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
longreprfield can be multiple types such as dictionary, tuple, and string. We have handled the only dictionary case right now. This PR address the problem.https://github.com/pytest-dev/pytest/blob/1d7d63555e431d4562bcacbdc97038b0613d20ba/src/_pytest/reports.py#L60