Skip to content

Conversation

@kohsuke
Copy link
Contributor

@kohsuke kohsuke commented Jul 29, 2025

  • Don't bother sending non-text files. The server can't deal with anyway
  • To differentiate multiple repositories within the same workspace, I decided to capture the repository name when collecting files.
  • (Boy scout rule) The deprecated scrub_pii switch was removed. It's always on.

Python side of the change that pairs up with the Java change earlier in
the history.

The notion of "repository name" is already present in `record build`, so
that change is straighforward. `record commit` needs a new option and
sensible default.
@sonarqubecloud
Copy link

@kohsuke kohsuke requested a review from Konboi July 29, 2025 19:51
@kohsuke kohsuke changed the title [AIENG-183] don't send non-text files [AIENG-183] changes for PTS v2 Jul 29, 2025
@kohsuke
Copy link
Contributor Author

kohsuke commented Jul 29, 2025

Actually, capturing the repository name creates a complexity on the server side to match test names to file names that I don't want to deal with right now.

@kohsuke kohsuke closed this Jul 29, 2025
@kohsuke kohsuke reopened this Aug 13, 2025
@kohsuke
Copy link
Contributor Author

kohsuke commented Aug 13, 2025

Either intentionally or unintentionally, I have already merged all the commits in this branch except for the last one which is for the Python side.

Without this commit in, Java side has the wrong repo name calculation, so might as well get this in, even though we aren't sending the repository name to the server.

@Konboi Konboi merged commit 94cd3d7 into main Aug 18, 2025
29 checks passed
@Konboi Konboi deleted the AIENG-183 branch August 18, 2025 01:49
@github-actions github-actions bot mentioned this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants