[chore] report an error in subset call #1127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like c41d9a6 removed the `raise_for_status` check, without which error message from the server won't be reported, even as a warning. This breaks the subset call in case of the server failure, since `res.json()` looks as if it's returning an empty subset
Konboi
approved these changes
Sep 16, 2025
Contributor
|
Thank you for fixing it. But it seems you should change the base from |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like c41d9a6 removed the
raise_for_statuscheck, without which error message from the server won't be reported, even as a warning.This breaks the subset call in case of the server failure, since
res.json()looks as if it's returning an empty subsetAssigning the review to @Konboi to make sure the change in c41d9a6 is unintentional.