Skip to content

Conversation

@ono-max
Copy link
Contributor

@ono-max ono-max commented Sep 16, 2025

======================================================================
FAIL [1.113s]: test_all_workflow_when_server_down (tests.commands.test_api_error.APIErrorTest.test_all_workflow_when_server_down)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/.local/share/virtualenvs/smart-tests-cli-djAcMpSV/lib/python3.11/site-packages/responses/__init__.py", line 232, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.13/x64/lib/python3.11/unittest/mock.py", line 1831, in _inner
    return f(*args, **kw)
           ^^^^^^^^^^^^^^
  File "/home/runner/work/smart-tests-cli/smart-tests-cli/tests/commands/test_api_error.py", line 440, in test_all_workflow_when_server_down
    self.assert_tracking_count(tracking=tracking, count=6)
  File "/home/runner/work/smart-tests-cli/smart-tests-cli/tests/commands/test_api_error.py", line 467, in assert_tracking_count
    assert tracking.call_count == count
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

======================================================================
FAIL [0.341s]: test_reason (tests.utils.test_http_client.HttpClientTest.test_reason)
make sure we correctly propagate error message from the server
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/smart-tests-cli/smart-tests-cli/tests/utils/test_http_client.py", line 57, in test_reason
    self.assertEqual(res.reason, "Welp")
AssertionError: '' != 'Welp'
+ Welp

@launchable-app

This comment has been minimized.

@ono-max ono-max marked this pull request as ready for review September 16, 2025 05:18
@ono-max ono-max requested review from gayanW and yoshiori September 16, 2025 05:18
# /error is an actual endpoint that exists on our service to test the behavior
res = cli.request("GET", "intake/error")
# /raise_error is an actual endpoint that exists on our service to test the behavior
res = cli.request("GET", "intake/raise_error")
Copy link
Contributor Author

@ono-max ono-max Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoshiori

FYI: Updated this endpoint because you modified the endpoint on the intake side.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test is meaningless.
Please remove this test case

@ono-max ono-max merged commit adfdc37 into v1 Sep 16, 2025
13 checks passed
@ono-max ono-max deleted the fix-ci-4 branch September 16, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants