Skip to content

Conversation

@gayanW
Copy link
Contributor

@gayanW gayanW commented Oct 6, 2025

This adds new command launchable inspect model.
This should only be merged after https://github.com/launchableinc/mothership/pull/12415

Usage:

% launchable inspect model
| Metadata                        |   Value |
|---------------------------------|---------|
| Training Cutoff Test Session ID |     256 |
% launchable inspect model --json
{
  "training_cutoff_test_session_id": 256
}

@gayanW gayanW requested review from kohsuke and ono-max October 6, 2025 01:18
def display_as_table(res: Response):
headers = ["Metadata", "Value"]
res_json = res.json()
rows = [["Training Cutoff Test Session ID", res_json['training_cutoff_test_session_id']]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could training_cutoff_test_session_id be null? If not, it's okay; otherwise, this throws KeyError, which is not our expectation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ono-max
Copy link
Contributor

ono-max commented Oct 6, 2025

What will happen if the subset is not enabled in the workspace? In other words, what error message will be displayed if the subset is not allows in the workspace?

@gayanW
Copy link
Contributor Author

gayanW commented Oct 7, 2025

What will happen if the subset is not enabled in the workspace? In other words, what error message will be displayed if the subset is not allows in the workspace?

I just tested. The /model-metadata endpoint only queries the models table. So it's not affected by the data in the workspace_feature_flags table. If DB entry for that workspace not found, or if the the value of the training_cutoff_test_session_id column is null, it returns 404. So in that case CLI would output:

"Model metadata currently not available for this workspace."

@gayanW gayanW merged commit 200bd0d into v1 Oct 10, 2025
13 checks passed
@gayanW gayanW deleted the LCHIB-638 branch October 10, 2025 02:15
@github-actions github-actions bot mentioned this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants