Skip to content

Conversation

@Konboi
Copy link
Contributor

@Konboi Konboi commented Oct 21, 2025

To balance the order, since "test", "spec", and etc tend to appear near the end in alphabetical sorting.

@Konboi Konboi requested a review from kohsuke October 21, 2025 04:14
Base automatically changed from add-get-tests-from-guess-field to v1 October 21, 2025 04:24
Copy link
Contributor

@kohsuke kohsuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a comment in code is in order to explain why this shuffle statement is here. Otherwise a future dev who stumbles upon this would be sure to wonder why.

…arget files in requests

[chore] add comments why we shuffle the list
@Konboi Konboi force-pushed the shuffle-before-send-files branch from 486af5c to 576ef00 Compare October 27, 2025 01:34
@Konboi Konboi merged commit 798f160 into v1 Oct 27, 2025
14 checks passed
@Konboi Konboi deleted the shuffle-before-send-files branch October 27, 2025 01:47
@github-actions github-actions bot mentioned this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants