Skip to content

subset: relax validation rule #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ono-max merged 1 commit into from
Jan 27, 2025
Merged

subset: relax validation rule #973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions launchable/commands/subset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,20 +218,6 @@ def subset(
app = context.obj
tracking_client = TrackingClient(Tracking.Command.SUBSET, app=app)

if is_observation and is_get_tests_from_previous_sessions:
Copy link
Contributor

@Konboi Konboi Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it some thought, we should change this validation
from if is_observation and is_get_tests_from_previous_sessions: to if is_observation and is_output_exclusion_rules: to prevent miss integration.

Copy link
Contributor Author

@ono-max ono-max Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've already checked those condition at https://github.com/launchableinc/cli/blob/main/launchable/commands/subset.py#L235, don't we?

Copy link
Contributor

@Konboi Konboi Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that. Thanks

msg = "Cannot use --observation and --get-tests-from-previous-sessions options at the same time"
click.echo(
click.style(
msg,
fg="red"),
err=True,
)
tracking_client.send_error_event(
event_name=Tracking.ErrorEvent.INTERNAL_CLI_ERROR,
stack_trace=msg,
)
sys.exit(1)

if is_observation and is_output_exclusion_rules:
msg = (
"WARNING: --observation and --output-exclusion-rules are set. "
Expand Down
Loading