fix(tunnel): improve ICMP proxy interface selection #1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On systems with Docker or other container runtimes, the ICMP proxy was selecting virtual bridge interfaces (br-*, docker*, veth*) instead of physical interfaces (eth*, enp*, ens*, wlan*). This change: - Adds interface filtering to exclude known virtual/bridge interfaces - Prioritizes physical interfaces when selecting ICMP source addresses - Changes fallback dial target from 192.168.0.1 to 8.8.8.8 for better default route detection - Applies the same filtering to IPv6 source selection The existing --icmpv4-src and --icmpv6-src flags continue to work as manual overrides. Fixes cloudflare#1546
HueCodes
force-pushed
the
fix/icmp-interface-selection
branch
from
9d1e927 to
0b90c42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ICMP proxy selecting Docker bridge interfaces instead of physical interfaces on systems with containers.
Fixes #1546