add protocol option (ssh or https) in config/settings.yml #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "example-app" breaks when the network (on which this app is deployed) can't use ssh port (22) for whatever reason, e.g. corporate FW setting. The error after "Create a commit" button is pressed may be as follows:
...
ssh: connect to host github.com port 22: Connection timed out
fatal: Could not read from remote repository.
...
This patch allows users to select https over ssh as git protocol if he/she likes. Also, when ssh is used, "The following SSH key was added to .." email message is coming whenever an app binds the service. It's a bit noisy in development.