-
Notifications
You must be signed in to change notification settings - Fork 36
Fix building to work with symlink to system tar in bosh bin dir #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cacls has a |
* stemcell building process Protect_Dir behavior didn't like the symlink
aramprice
previously approved these changes
Oct 9, 2025
Member
aramprice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me... the "skip_cleanup": ${SKIP_CLEANUP} code seems unrelated though, is this meant to be here?
* /L doesn't follow the links
This reverts commit 686e76f.
* removal of bsd tar 614bdc0 * garden-runc release where things were fixed: https://github.com/cloudfoundry/garden-runc-release/releases/tag/v1.76.0
aramprice
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect-DirandProtect-Pathwould try to follow that link intoC:\Windows\System32, and messing with ACLs on that dir wasn't a good idea.var\vcap\data,var\vcap\sys, etc). Basically, we would see that anything added in thevar\vcap\packagesorvar\vcap\syswould still have ACLS forBUILTIN\Users. I'm thinking that the existing implementation expects to be able to traverse links, which in the case of the data dir would be fine. Tried to get things working by messing with various cacls/icacls flags for inheritance, but after burning a couple days on it, decided it wasn't worth more effort. I think if we really wanted to do this, we'd have to add more granular ways to set permissions on things. But, considering we're gonna rip this out in the future anyway, I'm not sure it is worth it.