Skip to content

Conversation

@KauzClay
Copy link
Contributor

@KauzClay KauzClay commented Oct 6, 2025

  • copy system tar to bosh bin, stemcell building process Protect_Dir behavior didn't like the symlink I added in Symlink to old tar for backwards compatibility #101.
  • I believe this is because the cacls/icacls commands in Protect-Dir and Protect-Path would try to follow that link into C:\Windows\System32, and messing with ACLs on that dir wasn't a good idea.
  • I tried using the /L flag on cacls/icacls so that it would just stop at the link, but this led to some issues with the ACLs on the other linked dirs (var\vcap\data, var\vcap\sys, etc). Basically, we would see that anything added in the var\vcap\packages or var\vcap\sys would still have ACLS for BUILTIN\Users. I'm thinking that the existing implementation expects to be able to traverse links, which in the case of the data dir would be fine. Tried to get things working by messing with various cacls/icacls flags for inheritance, but after burning a couple days on it, decided it wasn't worth more effort. I think if we really wanted to do this, we'd have to add more granular ways to set permissions on things. But, considering we're gonna rip this out in the future anyway, I'm not sure it is worth it.
  • I left some a comment explaining why that line is there, and then I'll squash this but leave a pretty thorough commit message. Hopefully that is enough to remind future us what this was for and what the criteria for removing it are

@KauzClay KauzClay changed the title copy system tar to bosh bin Fix pipeline to work with system tar in bosh bin dir Oct 6, 2025
@KauzClay KauzClay marked this pull request as ready for review October 6, 2025 20:24
@KauzClay KauzClay changed the title Fix pipeline to work with system tar in bosh bin dir Fix stembuild to work with system tar in bosh bin dir Oct 6, 2025
@KauzClay KauzClay changed the title Fix stembuild to work with system tar in bosh bin dir Fix building to work with system tar in bosh bin dir Oct 6, 2025
@KauzClay
Copy link
Contributor Author

KauzClay commented Oct 6, 2025

cacls has a /l flag that could be used to allow symlinks also, might be worth trying out instead copying (docs)

@KauzClay KauzClay changed the title Fix building to work with system tar in bosh bin dir Fix building to work with symlink to system tar in bosh bin dir Oct 7, 2025
* stemcell building process Protect_Dir behavior didn't like the symlink
@rkoster rkoster requested review from aramprice and ragaskar October 9, 2025 15:21
@rkoster rkoster moved this from Inbox to Pending Review | Discussion in Foundational Infrastructure Working Group Oct 9, 2025
aramprice
aramprice previously approved these changes Oct 9, 2025
Copy link
Member

@aramprice aramprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... the "skip_cleanup": ${SKIP_CLEANUP} code seems unrelated though, is this meant to be here?

@github-project-automation github-project-automation bot moved this from Pending Review | Discussion to Pending Merge | Prioritized in Foundational Infrastructure Working Group Oct 9, 2025
* /L doesn't follow the links
@KauzClay KauzClay merged commit 4b0fbae into windows-2019 Oct 9, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Oct 9, 2025
@aramprice aramprice deleted the fix-pipeline branch October 9, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants