Can't push apps with app manifests if routes were shared #4344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if route shared with space and don't throw error if shared
Fix robocop errors
Fix rubocop error
tcdowney
reviewed
May 8, 2025
Move app and route space match to common method
Fix rubocop errors
Samze
reviewed
May 13, 2025
Rename method based on code review
Samze
approved these changes
May 14, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
May 14, 2025
Changes in cloud_controller_ng:
- Can't push apps with app manifests if routes were shared
PR: cloudfoundry/cloud_controller_ng#4344
Author: Sriram Nookala <snookala@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if route shared with space and don't throw error if shared
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
If the route is shared with the space don't throw error
Given org
org1with spacespaceorgorg2with spacespace2:cf push dorawith no manifest (so default-route is used)cf share-route thawing.app-runtime-interfaces.ci.cloudfoundry.org --hostname dora -o org2 -s space2this will return
OK, thinking the spaces are equal, though it wont actually be movedNOTE: The space names do not have to be the same
cf target -o org2 -s space2cf push doraagainObserve the error:
Routes cannot be mapped to destinations in different spacesLinks to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests