Skip to content

Conversation

@philippthun
Copy link
Member

@philippthun philippthun commented Jun 13, 2025

  • implementation of steps 3a and 3b for the events table
  • step 3a: add check constraint (NOT VALID) / run VALIDATE CONSTRAINT separately with longer timeout and less restrictive locks
  • step 3b: drop check constraint and trigger function / drop old id column / switch id_bigint -> id (index added concurrently)
  • down migration fully implemented for testing purposes
  • added comments to step 1 and step 3b down migrations - they should not be used in a production system
  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@philippthun philippthun force-pushed the bigint-migration-events-step3 branch 2 times, most recently from 6aaf1df to 29d1456 Compare June 26, 2025 12:51
@philippthun philippthun force-pushed the bigint-migration-events-step3 branch from 29d1456 to 5ef5cc8 Compare July 3, 2025 09:24
@philippthun philippthun force-pushed the bigint-migration-events-step3 branch 2 times, most recently from e8e1df1 to 4c39d2d Compare July 11, 2025 07:12
@philippthun philippthun marked this pull request as ready for review July 11, 2025 07:13
@philippthun philippthun force-pushed the bigint-migration-events-step3 branch 2 times, most recently from 1ff66d5 to fa979b0 Compare July 15, 2025 10:27
- implementation of steps 3a and 3b for the events table
- step 3a: add check constraint (NOT VALID) / run VALIDATE CONSTRAINT
  separately with longer timeout and less restrictive locks
- step 3b: drop check constraint and trigger function / drop old id
  column / switch id_bigint -> id (index added concurrently)
- down migration fully implemented for testing purposes
- added comments to step 1 and step 3b down migrations - they should not
  be used in a production system
@philippthun philippthun force-pushed the bigint-migration-events-step3 branch from fa979b0 to 18b25b9 Compare July 15, 2025 12:01
@philippthun philippthun merged commit 49c37e2 into cloudfoundry:main Jul 23, 2025
18 checks passed
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Jul 23, 2025
Changes in cloud_controller_ng:

- Bigint Migration for 'events' Table (Step 3)
    PR: cloudfoundry/cloud_controller_ng#4406
    Author: Philipp Thun <philipp.thun@sap.com>
jochenehret added a commit that referenced this pull request Oct 2, 2025
* step 3a and b for remaining tables: jobs, delayed_jobs, app_usage_events, service_usage_events
* see also #4406
jochenehret added a commit that referenced this pull request Oct 2, 2025
* step 3a and b for remaining tables: jobs, delayed_jobs, app_usage_events, service_usage_events
* see also #4406
jochenehret added a commit that referenced this pull request Oct 2, 2025
* step 3a and b for remaining tables: jobs, delayed_jobs, app_usage_events, service_usage_events
* see also #4406
jochenehret added a commit that referenced this pull request Oct 2, 2025
* step 3a and b for remaining tables: jobs, delayed_jobs, app_usage_events, service_usage_events
* see also #4406
jochenehret added a commit that referenced this pull request Oct 2, 2025
* step 3a and b for remaining tables: jobs, delayed_jobs, app_usage_events, service_usage_events
* see also #4406
jochenehret added a commit that referenced this pull request Oct 13, 2025
* step 3a and b for remaining tables: jobs, delayed_jobs, app_usage_events, service_usage_events
* see also #4406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants