Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4256 +/- ##
==========================================
+ Coverage 97.19% 97.31% +0.11%
==========================================
Files 886 888 +2
Lines 26038 26029 -9
Branches 9438 9409 -29
==========================================
+ Hits 25308 25329 +21
+ Misses 724 694 -30
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5f023e2 to
c378f24
Compare
2b7fefb to
18ab8f3
Compare
df22d00 to
d3df365
Compare
pan-kot
commented
Feb 17, 2026
| @@ -1,47 +0,0 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
Member
Author
There was a problem hiding this comment.
I renamed this file to "styles-check.test.tsx" as now there is a single util that we test.
pan-kot
commented
Feb 17, 2026
| @@ -1,185 +0,0 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
Member
Author
There was a problem hiding this comment.
I removed this file where the tests were done by calling checkMissingStyles and documentReadyAndIdle utils directly. Instead, all tests are now done against the useMissingStylesCheck.
I ensured that every test from this file is represented in the new tests.
d3df365 to
bfd5a47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The styles check util validates the presence of the component styles on the page and logs an error like
Missing AWS-UI CSS for theme...to the console when the styles are not present.This util causes integ tests flakiness with over 10 recorded occurrences.
The PR addresses the problem by making changes to the util so that it validates that the stylesheets (present upon document readiness) are loaded.
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.