Skip to content

fix: remove conditional call of hooks in useSetGlobalBreadcrumbs hook#4258

Open
SpyZzey wants to merge 2 commits intomainfrom
fix/breadcrumbs-hook-called-conditionally
Open

fix: remove conditional call of hooks in useSetGlobalBreadcrumbs hook#4258
SpyZzey wants to merge 2 commits intomainfrom
fix/breadcrumbs-hook-called-conditionally

Conversation

@SpyZzey
Copy link
Member

@SpyZzey SpyZzey commented Feb 16, 2026

Description

Fixes a bug that conditionally calls react hooks in useSetGlobalBreadcrumbs.
Issue: [D391653241].

How has this been tested?

  • Tested locally.
  • Tested in dev pipeline.
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.30%. Comparing base (62db9d6) to head (b2d21ed).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4258   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files         888      888           
  Lines       26012    26019    +7     
  Branches     9408     9412    +4     
=======================================
+ Hits        25312    25319    +7     
+ Misses        694      653   -41     
- Partials        6       47   +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SpyZzey SpyZzey marked this pull request as ready for review February 16, 2026 15:04
@SpyZzey SpyZzey requested a review from a team as a code owner February 16, 2026 15:04
@SpyZzey SpyZzey requested review from pan-kot and removed request for a team February 16, 2026 15:04
Copy link
Member

@georgylobko georgylobko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reproduce the original issue in the unit test environment you're targeting? That would verify your fix works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants