Skip to content

Comments

feat: Update swagger-codegen to v2.4.50 and regenerate bindings#83

Closed
nickbroon wants to merge 4 commits intocloudsmith-io:masterfrom
nickbroon:nickb/swagger-codegen-update
Closed

feat: Update swagger-codegen to v2.4.50 and regenerate bindings#83
nickbroon wants to merge 4 commits intocloudsmith-io:masterfrom
nickbroon:nickb/swagger-codegen-update

Conversation

@nickbroon
Copy link
Contributor

@nickbroon nickbroon commented Jan 5, 2026

This mainly to pick up the fixes for generated python bindings logging,
which wasn't following python best practice for stream handling.

The complete changelog for swagger-codegen can be found at:
https://github.com/swagger-api/swagger-codegen/releases

relates to:

This mainly to pick up the fixes for generated python bindings logging,
which wasn't following python best practice for stream handling.

The complete changelog for swagger-codegen can be found at:
https://github.com/swagger-api/swagger-codegen/releases
- Regenerated bindings for Python, Ruby, and Java
@nickbroon
Copy link
Contributor Author

I'm not sure if there are gitlab workflow/action automation that perform checks on pull-requests?

@chrisimcevoy, @apoclyps, tagging you as recent contributors to this project....

Copy link
Contributor

@chrisimcevoy chrisimcevoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@apoclyps apoclyps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nickbroon,

Thanks for your contributions! The changes you’ve submitted look great.

We typically release our API bindings in lockstep with the Cloudsmith-CLI (example
), which first undergoes developer testing, followed by a more thorough set of internal tests. @chrisimcevoy has already reached out to the @cloudsmith-io/customer-engineering team via Slack to bring this to their attention.

@apoclyps apoclyps changed the title Update swagger-codegen to v2.4.50 and regenerate bindings feat: Update swagger-codegen to v2.4.50 and regenerate bindings Jan 5, 2026
Copy link
Member

@BartoszBlizniak BartoszBlizniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BartoszBlizniak
Copy link
Member

Hey @nickbroon - thank you for the contribution!

Since you have not set up verified signatures, which is a requirement for all Cloudsmith PRs (I recommend setting this up for future contributions), I have opened a new PR to meet the merge requirements and will close off this PR.

#84

@nickbroon
Copy link
Contributor Author

Since you have not set up verified signatures, which is a requirement for all Cloudsmith PRs (I recommend setting this up for future contributions)

Apologies. I had not realised that signed commits was a requirement. I didn't notice any mention of these in https://docs.cloudsmith.com/contributing or https://github.com/cloudsmith-io/cloudsmith-api/blob/master/CONTRIBUTING.md. I'll make sure to sign my commits for any future contributions.

BartoszBlizniak added a commit that referenced this pull request Jan 9, 2026
* feat: update to use swagger-codegen-cli v2.4.50

This mainly to pick up the fixes for generated python bindings logging,
which wasn't following python best practice for stream handling.

The complete changelog for swagger-codegen can be found at:
https://github.com/swagger-api/swagger-codegen/releases

(cherry picked from commit 6afcd9d)

* feat: update bindings to v2.0.23

(cherry picked from commit ccf7f36)

* Update API bindings to version 2.0.23

- Regenerated bindings for Python, Ruby, and Java

(cherry picked from commit 008cbd4)

* update ruby test commands to support running tests on 3.4 locally

(cherry picked from commit a7a9585)

* pre-commit with ruff

---------

Co-authored-by: Nick Brown <nickbroon@graphiant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants