feat: Update swagger-codegen to v2.4.50 and regenerate bindings#83
feat: Update swagger-codegen to v2.4.50 and regenerate bindings#83nickbroon wants to merge 4 commits intocloudsmith-io:masterfrom
Conversation
This mainly to pick up the fixes for generated python bindings logging, which wasn't following python best practice for stream handling. The complete changelog for swagger-codegen can be found at: https://github.com/swagger-api/swagger-codegen/releases
- Regenerated bindings for Python, Ruby, and Java
|
I'm not sure if there are gitlab workflow/action automation that perform checks on pull-requests? @chrisimcevoy, @apoclyps, tagging you as recent contributors to this project.... |
There was a problem hiding this comment.
Hi @nickbroon,
Thanks for your contributions! The changes you’ve submitted look great.
We typically release our API bindings in lockstep with the Cloudsmith-CLI (example
), which first undergoes developer testing, followed by a more thorough set of internal tests. @chrisimcevoy has already reached out to the @cloudsmith-io/customer-engineering team via Slack to bring this to their attention.
|
Hey @nickbroon - thank you for the contribution! Since you have not set up verified signatures, which is a requirement for all Cloudsmith PRs (I recommend setting this up for future contributions), I have opened a new PR to meet the merge requirements and will close off this PR. |
Apologies. I had not realised that signed commits was a requirement. I didn't notice any mention of these in https://docs.cloudsmith.com/contributing or https://github.com/cloudsmith-io/cloudsmith-api/blob/master/CONTRIBUTING.md. I'll make sure to sign my commits for any future contributions. |
* feat: update to use swagger-codegen-cli v2.4.50 This mainly to pick up the fixes for generated python bindings logging, which wasn't following python best practice for stream handling. The complete changelog for swagger-codegen can be found at: https://github.com/swagger-api/swagger-codegen/releases (cherry picked from commit 6afcd9d) * feat: update bindings to v2.0.23 (cherry picked from commit ccf7f36) * Update API bindings to version 2.0.23 - Regenerated bindings for Python, Ruby, and Java (cherry picked from commit 008cbd4) * update ruby test commands to support running tests on 3.4 locally (cherry picked from commit a7a9585) * pre-commit with ruff --------- Co-authored-by: Nick Brown <nickbroon@graphiant.com>
This mainly to pick up the fixes for generated python bindings logging,
which wasn't following python best practice for stream handling.
The complete changelog for swagger-codegen can be found at:
https://github.com/swagger-api/swagger-codegen/releases
relates to: