Open
Conversation
URL was incorrect and contradictory to the screenshot
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Google (G-Suite) SSO setup guide to use the correct Cloudsmith SAML ACS/Entity ID URL format, aligning the written instructions with the expected URL structure.
Changes:
- Corrected the SAML ACS URL / Entity ID example to include the
/orgs/path segment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ### Step 7 | ||
|
|
||
| In Step 4, _Service Provider Details_, enter: `https://cloudsmith.io/MY_ORG_NAME/saml/acs/` as the _ACS URL_ and _Entity ID_, where "MY_ORG_NAME" is replaced with your organization's slug (i.e. what your normally see in the URL bar for your organization). | ||
| In Step 4, _Service Provider Details_, enter: `https://cloudsmith.io/orgs/MY_ORG_NAME/saml/acs/` as the _ACS URL_ and _Entity ID_, where "MY_ORG_NAME" is replaced with your organization's slug (i.e. what your normally see in the URL bar for your organization). |
There was a problem hiding this comment.
Grammar: the parenthetical says "what your normally see"; this should be "what you normally see".
Suggested change
| In Step 4, _Service Provider Details_, enter: `https://cloudsmith.io/orgs/MY_ORG_NAME/saml/acs/` as the _ACS URL_ and _Entity ID_, where "MY_ORG_NAME" is replaced with your organization's slug (i.e. what your normally see in the URL bar for your organization). | |
| In Step 4, _Service Provider Details_, enter: `https://cloudsmith.io/orgs/MY_ORG_NAME/saml/acs/` as the _ACS URL_ and _Entity ID_, where "MY_ORG_NAME" is replaced with your organization's slug (i.e. what you normally see in the URL bar for your organization). |
| ### Step 7 | ||
|
|
||
| In Step 4, _Service Provider Details_, enter: `https://cloudsmith.io/MY_ORG_NAME/saml/acs/` as the _ACS URL_ and _Entity ID_, where "MY_ORG_NAME" is replaced with your organization's slug (i.e. what your normally see in the URL bar for your organization). | ||
| In Step 4, _Service Provider Details_, enter: `https://cloudsmith.io/orgs/MY_ORG_NAME/saml/acs/` as the _ACS URL_ and _Entity ID_, where "MY_ORG_NAME" is replaced with your organization's slug (i.e. what your normally see in the URL bar for your organization). |
There was a problem hiding this comment.
The placeholder is "MY_ORG_NAME" here, but later the guide uses "WORKSPACE" (e.g. the app.cloudsmith.com URL). Consider using a single placeholder consistently throughout the guide to avoid confusing readers about what value to substitute.
Suggested change
| In Step 4, _Service Provider Details_, enter: `https://cloudsmith.io/orgs/MY_ORG_NAME/saml/acs/` as the _ACS URL_ and _Entity ID_, where "MY_ORG_NAME" is replaced with your organization's slug (i.e. what your normally see in the URL bar for your organization). | |
| In Step 4, _Service Provider Details_, enter: `https://cloudsmith.io/orgs/WORKSPACE/saml/acs/` as the _ACS URL_ and _Entity ID_, where "WORKSPACE" is replaced with your organization's slug (i.e. what your normally see in the URL bar for your organization). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL was incorrect and contradictory to the screenshot