Fix: credit arg, database hygiene, and stale globals cleanup #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass the patch instance (not the patch class) to testcredit()/reportcredit() in gitdm.py and cncfdm.py - Close the database dump file handle in DumpDB() - Avoid mutable default args in FileType and treat empty patterns/order correctly - Make MapToEmployer() handle unsupported `unknown` values safely by defaulting to email mapping - Keep/restore LookupEmployer() signature (fix accidental syntax break) - Remove stale `Aggregate` global declarations in gerritdm.py and lpdm.py - Remove a trailing comma in reports.py Pct() call Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a few correctness and hygiene issues across the data-mining scripts:
patchclass reference)What changed
Correct patch credit attribution
src/gitdm.pyandsrc/cncfdm.py,testcredit()/reportcredit()now receive the actual patch instance (p/pa) rather than thepatchclass.Database utility + safer defaults
DumpDB()now closesdatabase.dumpafter writing.FileType.__init__()now avoids mutable default arguments;guess_file_type()now treats emptypatterns/orderas valid overrides (usesis not Noneinstead ofor).MapToEmployer()now safely defaults to the email-based employer mapping when an unsupportedunknownhandling value is passed.LookupEmployer()signature is intact (fixes an accidental broken definition).CLI parsing cleanup
src/gerritdm.pyandsrc/lpdm.py, removed staleAggregatefrom theglobaldeclaration inParseOpts().Minor report formatting
src/reports.py, removed a trailing comma in aPct()call.Files changed
src/cncfdm.pysrc/database.pysrc/gerritdm.pysrc/gitdm.pysrc/lpdm.pysrc/reports.py