Fix runner scripts and PowerShell wrapper (correct cncfdm path + stdin passthrough) #947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several runner scripts referenced ~/dev/cncf/gitdm/cncfdm.py, but the engine lives under src/cncfdm.py. This breaks common workflows driven by rerun_data.sh (run_no_map/run_with_map, strict/no-map release runs, multirepo runs, and commits-in-range analysis) unless the user has a custom copy/symlink. Also fix gitdm.ps1 on Windows PowerShell: - remove bash heredoc usage - correctly invoke "py -2" with arguments - forward piped stdin to cncfdm.py when used in a pipeline Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the scripts used to run gitdm analytics so they correctly locate the checked-in engine (
src/cncfdm.py) and config base directory, and fixes the PowerShell wrapper so it works on Windows.Root causes
src/rerun_data.shreferenced a non-existent./all.sh.~/dev/cncf/gitdm/cncfdm.pyand-b ~/dev/cncf/gitdm/, but the repo layout usessrc/cncfdm.pyand expects-b .../src/.gitdm.ps1used bash heredoc syntax and did not correctly invokepy -2or forward piped input.What changed (high level)
gitdm.ps1: reliable Python 2 detection/invocation and pipeline stdin passthrough.src/rerun_data.sh: call./run_all.shinstead of missing./all.sh.src/run_all.sh,src/all_no_map.sh,src/all_with_map.sh: useGITDM_HOME(script-relative) rather than hard-coded~/dev/...paths.src/run_no_map.sh,src/run_with_map.sh,src/run_for_rels_no_map.sh,src/run_for_rels_strict.sh,src/anyrepo.sh,src/anyreporange.sh,src/multirepo.sh,src/commits_in_ranges.sh: deriveGITDM_HOMEand use"$GITDM_HOME/src/cncfdm.py"with-b "$GITDM_HOME/src/".Impact
src/rerun_data.sh) by fixing missing/broken script targets and engine paths.~/dev/cncf/gitdm/.Validation
~/dev/cncf/gitdm/cncfdm.pyfile.Confirmation
These changes are focused on correctness of script execution paths and wrapper behavior; they do not change the underlying gitdm/cncfdm analysis behavior.