pkg/resource: Add migration label support to CrdbCluster CR #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pritesh-lahoti
approved these changes
Dec 22, 2025
| .PHONY: release/publish-openshift-bundle | ||
| release/publish-openshift-bundle: | ||
| ./build/release/teamcity-publish-openshift-bundle.sh | ||
|
|
There was a problem hiding this comment.
nit: changes to this file seem unnecessary and could be reverted.
NishanthNalluri
force-pushed
the
nishanth/migration
branch
from
f57ad1a to
a35ef22
Compare
pritesh-lahoti
approved these changes
Dec 29, 2025
NishanthNalluri
force-pushed
the
nishanth/migration
branch
5 times, most recently
from
e1d69f8 to
e29f2db
Compare
To support migrating CockroachDB clusters from the public operator to the CockroachDB operator through coexistence, we need to prevent the operator from reverting manual changes made during the migration process. This includes preventing the scale-up of StatefulSet pods after manual scale-down and allowing modifications to Service labels (e.g., public service) which would otherwise be reset by the operator. This commit introduces a new migration label (`crdb.io/skip-reconcile`) in the v1alpha1 API. When this label is set to "true" on the CrdbCluster resource, the controller stops the entire reconciliation loop. This ensures the operator does not interfere with any resources during the migration phase.
NishanthNalluri
force-pushed
the
nishanth/migration
branch
from
e29f2db to
124dfc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support migrating CockroachDB clusters from the public operator to the CockroachDB operator through coexistence, we would need additional logic to prevent the operator from scaling up StatefulSet pods after they have been manually scaled down.
This commit introduces a new migration label(
crdb.io/stop-public-operator-reconcile) for the CrdbCluster resource. When this label is applied, the reconciler is instructed to skip updates to the relevant StatefulSet replicas. This ensures the operator does not interfere with the controlled scale-down process required during the migration phase.