backup: still set rev start time for empty incrementals #160130
Merged
+52
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, empty incremental backups would not set revision start time in the backup manifest. This commit fixes the backup processor to still set the revision start time when writing no data. Epic: None Release note: None
Member
|
This change is |
There was a problem hiding this comment.
Pull request overview
This PR fixes empty incremental backups with revision history to properly set the revision start time in the backup manifest. Previously, when an incremental backup exported no data, the revision start time field was not populated even for revision history backups.
- Sets
revStarttimestamp for empty spans whenMVCCFilter_Allis used (revision history backups) - Ensures
flushedRevStartis forwarded inWriteWithNoDatamethod and included in progress updates - Adds proper cleanup with
flushedRevStart.Reset()after flushing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/backup/backup_processor.go | Conditionally sets revStart timestamp for empty export responses when using revision history (MVCCFilter_All) |
| pkg/backup/backupsink/file_sst_sink.go | Updates WriteWithNoData to track revision start time and ensures it's included in progress updates during flush |
| pkg/backup/backup_test.go | Adds comprehensive test coverage for both revision history and non-revision history empty incremental backups |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
msbutler
approved these changes
Jan 2, 2026
Contributor
Author
|
TFTR! bors r=msbutler |
Contributor
|
Build succeeded! And happy new year! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, empty incremental backups would not set revision start time in the backup manifest. This commit fixes the backup processor to still set the revision start time when writing no data.
Epic: None
Release note: None