-
Notifications
You must be signed in to change notification settings - Fork 1
Embedder rework #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Embedder rework #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2025
JWittmeyer
reviewed
Jul 30, 2025
JWittmeyer
reviewed
Jul 30, 2025
JWittmeyer
reviewed
Jul 30, 2025
JWittmeyer
reviewed
Jul 30, 2025
JWittmeyer
reviewed
Jul 30, 2025
JWittmeyer
reviewed
Jul 30, 2025
JWittmeyer
reviewed
Jul 30, 2025
JWittmeyer
reviewed
Jul 30, 2025
JWittmeyer
reviewed
Jul 30, 2025
JWittmeyer
reviewed
Jul 30, 2025
Member
Member
|
i think we can remove token embeddings as option for the embeddings since they are not being used
|
Member
|
I dont think the migration dry run works as intendet. The files are already moved to a backup folder and the log says nothing was changed even though it should have one project with three embedings to be changed
|
JWittmeyer
approved these changes
Jul 30, 2025
perf: use pickle.dumps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Main PR: #160
Related PRs:
Note
New repository to be used as a "single-run" migration container: refinery-embedder-migration. Migration steps are available in the PR descriptions:
Local Testing
git clone https://github.com/code-kern-ai/refinery-embedder-migrationdev-setup:bash stoprefinery-embedder-migration:bash start dry-run qdrant-cleanup(theqdrant-cleanupargument is used to perform a Qdrant cleanup. Run dry by adding adry-runargument)~/repos/dev-setup/inference. It should contain abackupfolder with old embedders. Each<project-id>/<embedding-id>directory should containembedder.jsonorreducer.pklor bothdev-setup, runbash start -a -b embedder-rework~/repos/dev-setup/inference/backupAffected Areas
src/controller/strategy_steps(andsrc/controller/pipeline/steps/strategy_steps/neural_search.py)