Skip to content

Embedder rework #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andhreljaKern merged 2 commits into from
Jul 30, 2025
Merged

Embedder rework #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ebe710
feat: embedder rework
andhreljaKern Jul 25, 2025
6d221bc
fix: get min vector distance instead of max
andhreljaKern Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion business_objects/embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ def get_match_record_ids_to_qdrant_ids_with_max_score(
query = f"""
{__generate_with_table_union_query(qdrant_results)}

SELECT et.record_id::TEXT id, MAX(s.score) score
SELECT et.record_id::TEXT id, MIN(s.score) score
FROM embedding_tensor et
INNER JOIN scores s
ON et.id = s.id
Expand Down
2 changes: 0 additions & 2 deletions enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,9 +522,7 @@ class AgreementType(Enum):


class EmbeddingPlatform(Enum):
PYTHON = "python"
HUGGINGFACE = "huggingface"
COHERE = "cohere"
OPENAI = "openai"
AZURE = "azure"

Expand Down